kubeovn / kube-ovn / 31683391705
32%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 235
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 32.383% (+0.1%) from 32.234%
31683391705

push

github

web-flow 
e2e: trim the iptables eip qos specs to a natgw and an eip case (#7228)

The qos-policy suite took ~21 minutes, most of it spent in 38 iperf runs and
5 full test environments (2 VPCs + 2 NAT gateways each).

- Merge "default nic qos", "qos priority matching" and "create resource with
  qos policy" into a single "natgw qos" spec, and "eip qos" with "multi-eip
  qos isolation with decimal rates" into a single "eip qos" spec.
- Drop the "no qos means full bandwidth" checks: saturating the link is
  expensive and flaky. Unbinding a policy is now verified by falling back to
  another expected rate limit instead.
- Space every two rate limits which are compared against each other by a
  factor of 5, and cover the hot update of a bound policy in both directions
  (10 -> 50 -> 10 Mbps).
- Verify the tc classes instead of running iperf again after the NAT gateway
  pod is recreated, and wait for the old pods to disappear before waiting for
  readiness, which used to return before the gateway was rebuilt.
- Bind the QoS policies at NAT gateway/EIP creation time and unbind them
  before the policies get deleted, so the cleanup is not blocked by the
  controller finalizer.
- Create only the VPC, subnet and NAT gateway for the finalizer specs.

iperf runs: 38 -> 18, full test environments: 5 -> 2.

test(controller): cover the qos policy update restrictions

A NatGw bound QoS policy must be shared, and the bandwidth limit rules of a
shared policy cannot be changed: the limits of a NAT gateway can only be
changed by binding it to another policy. An unshared EIP policy supports the
hot update of its rules, but only while it is bound to at most one EIP.

None of these restrictions was covered, add unit tests for validateQosPolicy
and handleUpdateQoSPolicy. The fake controller now knows about QoS policies
and iptables EIPs.

e2e: cover the rule set changes and the unbinding of a qos policy

Updating a bound EIP QoS policy in place may not only change the rate of a
rule... (continued)

20913 of 64581 relevant lines covered (32.38%)

0.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31683391705.1 235
32.38
 GitHub Action Run
Source Files on build 31683391705