IgniteUI / igniteui-webcomponents / 31679721170

98%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(calendar): Calendar improvements and bug fixes (#2325)

Three defects reachable from the shipped components, plus the refactoring
their diagnosis called for.

`week-start` never reached the days grid. `_firstDayOfWeek` was derived in
the base component's `update()`, which runs after the days view has already
generated its dates, so the grid was laid out with the previous value while
the weekday labels above it were correct. A March 2025 calendar with
`week-start="monday"` started its grid on Sunday, February 23rd. The first
day of the week is now derived on access, removing the ordering hazard
altogether.

Keyboard navigation could hang the browser. Arrow, `Page Up`/`Page Down`,
`Home` and `End` skip disabled dates by walking day by day until they find
an enabled one, and that walk was unbounded. Any descriptor set leaving no
enabled date ahead - the `min`/`max` of the pickers translate into exactly
such open-ended `After`/`Before` ranges, as does `Weekdays` combined with
`Weekends` - looped forever. The search is bounded now, and the active date
stays where it is when nothing is reachable.

A multi-month calendar exposed one tab stop per visible month. Each view
derived `tabindex` from its own active date, while the `active` property the
calendar was already passing down was read by nothing - not the template,
not the styles. It now gates the tab stop, and defaults to `true` so that a
standalone `igc-days-view` keeps one.

Also `convertToDateRange` returns null instead of throwing out of an
attribute converter on malformed JSON, and time-only strings resolve against
the local date rather than the UTC one, which shifted the parsed date by a
day near midnight in some zones.

Structure:

- move the date model, converters and comparisons to src/internals/date.
  `internals/validators.ts` and the form transformers imported them from
  `components/calendar/`, inverting the layering. `helpers.ts` is left with
  the view geometry and the `DateRangeD... (continued)

Coverage Stats

6724 of 7048 branches covered (95.4%)

Branch coverage included in aggregate %.

957 of 967 new or added lines in 23 files covered. (98.97%)

1 existing line in 1 file now uncovered.

47666 of 48241 relevant lines covered (98.81%)

1439.62 hits per line