Borewit / music-metadata / 31629795486

96%

push

github

Read the Ogg/Speex comment header

SpeexStream overrode parseFirstPage but not parseFullPage, so it inherited
the Vorbis implementation. That one reads a CommonHeader, a packet-type byte
followed by the "vorbis" signature, and switches on the packet type.

A Speex comment packet has neither. The bytes at that offset are the start of
the vendor string length, so the packet type is whatever the low byte of that
length happens to be, no case matches, and the comments are silently
discarded. Files reported no tagTypes at all.

Per RFC 5574 section 3 the packet after the identification header is the
comment header, in Vorbis comment format but with no packet type or magic
signature, so it is parsed from offset 0. Later packets are audio and are
ignored.

1618 of 1821 branches covered (88.85%)

Branch coverage included in aggregate %.

8665 of 8914 relevant lines covered (97.21%)

55202.33 hits per line