optimizely / swift-sdk / 31625346965

94%

push

github

[AI-FSSDK] [FSSDK-12735] Add holdout exclusion logic for Targeted Delivery rules (#654)

* [AI-FSSDK] [FSSDK-12735] Add holdout exclusion logic for Targeted Delivery rules

* [AI-FSSDK] [FSSDK-12735] Fix holdout exclusion for global-only scope, null TD fallback, and holdout event dispatch

* [AI-FSSDK] [FSSDK-12735] Fix holdout decisionEventDispatched and add excludeTargetedDeliveries reason

* [AI-FSSDK] [FSSDK-12735] Implement excludeTargetedDeliveries for global holdouts

- Refactor getDecisionForFlag: skip experiment rules when global holdout has
  excludeTargetedDeliveries=true, always evaluate rollout (delivery) rules
- Attach holdoutDecision to rollout result so holdout impression fires
  alongside the rollout impression; attach to empty decision when no rollout
  matches so the holdout impression still fires
- Add HoldoutDecision struct replacing the anonymous holdoutToSend tuple;
  failable init?(from:) absorbs the unwrapping logic previously spread
  across call sites and the holdoutTuple helper
- Add userBucketedIntoRollout / userNotBucketedIntoRollout log messages
  matching Java SDK parity
- Refactor getDecisionForFlag and extract getTargetedDeliveryExperiments
  on ProjectConfig
- Fix DecisionServiceTests_ExcludeTargetedDeliveries: correct test setup
  ordering (project mutations before holdoutConfig assignment to prevent
  didSet from wiping the custom holdout), update assertions to match correct
  spec (experiments skipped, delivery/rollout rules always evaluated)

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* [FSSDK-12735] Re-trigger FSC tests after datafile updates

* Update CHANGELOG.md

* Update CHANGELOG.md

* [FSSDK-12735] Fix ETD reason message to use double quotes around holdout key

FSC asserts the reason string with double quotes ("holdoutKey") but the
SDK was emitting single quotes ('holdoutKey'), causing the subset match
to fail. Update the unit test to match the corrected format.

Co-Authored-By... (continued)

2 of 2 new or added lines in 1 file covered. (100.0%)

1145 of 1219 relevant lines covered (93.93%)

8918.61 hits per line