Unleash / unleash-python-sdk / 31611485319
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 21
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 94.0% (+0.6%) from 93.428%
31611485319

push

github

web-flow 
Create new EventDispatcher to move user-provided callback execution out of the main thread (#403)

* wip fix(events): move callback invocation outside of hot path

* refactor: move constants closer to where used

* refactor: remove unused options

we'll cross that bridge when we get to that river

* style: add missing type annotations

* chore: remove comment on the purpose of the timeout

I feel like this is self explanatory, happy to reconsider, though.

* fix: revert to a version of Iterator compatible with Python 3.8

* refactor: turn SHUTDOWN into a class-based sentinel

Using an instance of object was a bit awkward

* fix: hold the lock while enqueuing and release markers after closing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: change default max queue size

* refactor(events): delete `flush()`

flush is not something the callers of EventDispatcher are going to
use. Increasing the public api of the class for the sake of testing
makes no sense.

* refactor(events): hold lock for whole operations

in an effort to simplify the EventDispatcher, so that correctness
is easier to achieve, I'm refactoring the code to make it simpler.

No more flush markers. Shutdown renders the event dispatcher
"unusable" after calling "close()"

* feat: add close() to destructor

* docs: comment on why passing on the exception makes sense

* docs: make docstring on close() a bit clearer

* docs: more docstrings and a type that was missing

* test: exercise simpler implementation with more exhaustive tests

* fix: only wait for shutdown signal if there was a thread

* fix: warn only once about the queue being full

* fix: remove blocking destructor

* fix: typo

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: do not wait for shutdown signal if work... (continued)

799 of 850 relevant lines covered (94.0%)

0.94 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31611485319.1 21
94.0
 GitHub Action Run
Source Files on build 31611485319