lsm / HyperNeo / 31602832721

80%

push

github

feat(space): read-only list_subscriptions diagnostic tool [#908] (#2456)

* feat(space): read-only list_subscriptions diagnostic tool [#908]

PR 6 of the external-event subscription refactor. Adds a read-only MCP tool
that snapshots a workflow run's external-event subscriptions across three
layers — declared (workflow definition), persisted (PR 5 table), and active
(in-memory trie) — so an agent can answer "is this node actually subscribed
to these events?" from durable state alone.

Durable layers (declared + persisted) are the source of truth; the trie is
shown only as a live cross-check, with each active entry reconciled against
durable state (source: declared/persisted/orphan) and durable rows missing
from the trie surfaced via active=false plus a mismatches summary. For task
#896 this shows "Coding node has no declared PR-event interest" from durable
data alone.

- TopicTrie.values(): enumerate all stored values (read-only, for diagnostics).
- SpaceWorkflowEventSubscriptionRepository.listByRun(): run-scoped durable read
  (PR 5 removed the unused method; the diagnostic tool now needs it).
- SpaceRuntime.listSubscriptions(): three-layer snapshot + reconciliation,
  scoped by run + optional nodeId, guarded by spaceId.
- list_subscriptions MCP tool (node-agent): schema + handler + registration
  gated on an injected onListSubscriptions callback, wired in TaskAgentManager
  via SpaceRuntimeService.listSubscriptions.

* fix(space): address list_subscriptions review feedback [#908]

P1: gate mismatches.declaredNotActive on the canonical task being
non-terminal. registerRunInterestsFromWorkflow deliberately skips static
re-materialization for a done/archived/cancelled task (its static interests
are cleared by the task lifecycle), so the diagnostic was reporting every
declared interest on a finished run as drift — the exact false signal a
"finished run" investigation would hit. The declared list is still shown
(accurate, with active:false); only the drif... (continued)

18997 of 55573 branches covered (34.18%)

Branch coverage included in aggregate %.

2 of 84 new or added lines in 7 files covered. (2.38%)

28845 of 66629 relevant lines covered (43.29%)

234.4 hits per line