supabase / supabase-swift / 31580890787

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(storage): derive content type for signed URL uploads (#1158)

* fix(storage): derive content type for signed URL uploads

uploadToSignedURL fell back to defaultFileOptions when no options were
passed, and that constant carries contentType "text/plain;charset=UTF-8".
The fallback to the path extension could therefore never run, so a PNG or
JPEG uploaded through a signed URL was stored and served as text/plain.

upload() and update() already default to FileOptions(), whose contentType is
nil so the extension is used, and the deprecated uploadToSignedURL overloads
pass FileOptions() too. Use FileOptions() here as well. cacheControl and
upsert are identical between the two, so only contentType changes.

The two new tests capture the request body through StorageHTTPSession rather
than snapshotRequest, so they fail when the emitted content type is wrong.

* test(storage): move body-capturing helper beside makeSUT

* test(storage): fix Linux CI failure and stale snapshot in signed upload tests

The two new tests asserting extension-derived content type hardcoded
image/png and image/jpeg, which only holds where UniformTypeIdentifiers
is available; on Linux mimeType(forPathExtension:) falls back to
application/octet-stream. Also updates the uploadToSignedURLCleansPath
snapshot, which still expected the pre-fix Content-Length/Content-Type
values flagged by CodeRabbit.

---------

Co-authored-by: Guilherme Souza <guilherme@supabase.io>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

9 existing lines in 1 file now uncovered.

8773 of 10418 relevant lines covered (84.21%)

39.68 hits per line