UI5 / cli / 31575410407

94%

push

github

fix(server): Sequence destroy() after native teardown

Supervisor.destroy() passed the caller's callback to http.Server.close(),
firing it on socket close. The BuildServer's teardown (the @parcel/watcher
unsubscribe and the node:sqlite handle, which maps a 256 MB region of the
database into memory) runs after that call and was not sequenced ahead of
the callback, so server.close(resolve) resolved with SQLite still mid-close.
The next test.serial opening a fresh DatabaseSync, or the worker exiting,
then races the finalizing handle and raises an access violation on Windows
(0xC0000005), surfacing as `exited with a non-zero exit code: 3221225477`
in the reinitialize suite.

Make destroy() a plain promise: start the socket close, then await the
definition watcher and BuildServer teardown, and await the socket last.
The promise resolves only once every native handle is closed. server.js
adapts this to the existing close(callback) API and also returns the
promise when no callback is passed, so callers can await it; a teardown
error is passed to the callback (and rejects the promise) instead of
being swallowed.

7244 of 7979 branches covered (90.79%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 2 files covered. (100.0%)

13858 of 14446 relevant lines covered (95.93%)

5303.25 hits per line