Qiskit / qiskit / 31534121907

88%

main: 88%

Build Type

Pull #16744

github

Committed by mergify[bot]

Commit Message

dagcircuit: transfer DAG-level variables in `substitute_node_with_dag` (#15542)

* dagcircuit: transfer DAG-level variables in substitute_node_with_dag (fixes #15509)\n\n- Add input/captured/declared vars and stretches from replacement DAG\n- Add tests verifying input vars and captured/declared vars transfer\n- Add release note entry

* Apply Black formatting to test file

* Update test_dagcircuit.py

* Fix variable transfer to skip already-present variables

Previously, substitute_node_with_dag() would try to add all variables
from the replacement DAG, including those already present in the target
DAG. This violated the constraint that a DAG cannot have both input and
captured variables simultaneously when the same variable object appears
in both contexts.

Now check if each variable is already present before adding it, matching
the behavior of compose() with inline_captures=False.

* addressing review comments

* fixing failing check for node variable substitution in dagcircuit. The check was failing because the node variable substitution was not being applied correctly in the dagcircuit code. This commit fixes that issue by ensuring that the node variable substitution is applied correctly when checking for node variables in the dagcircuit code.

* adressing review comments

* reno

(cherry picked from commit f671c03bb)

Pull Request Pull Request #16744: dagcircuit: transfer DAG-level variables in `substitute_node_with_dag` (backport #15542)

Coverage Stats

16 of 20 new or added lines in 1 file covered. (80.0%)

6 existing lines in 2 files now uncovered.

113004 of 128786 relevant lines covered (87.75%)

997814.57 hits per line