tethysplatform / tethys / 31533216364

100%

push

github

Add node_modules to STATICFILES_DIRS when STATICFILES_USE_NPM is enabled (#1291)

* Add node_modules to STATICFILES_DIRS when STATICFILES_USE_NPM is enabled

- settings.py only appended node_modules to STATICFILES_DIRS when
  STATICFILES_USE_NPM was set under TETHYS_PORTAL_CONFIG
- The generic settings loader later applies any remaining top-level keys
  to the Django settings module, so STATICFILES_USE_NPM declared at the
  top level of the `settings` block would enable NPM mode, switching
  templates from CDN to /static/ URLs without ever adding
  node_modules to the static paths
- The portal then requested local JavaScript and CSS dependencies that
  were never served, returning 404s and leaving the portal unstyled
- Also check for STATICFILES_USE_NPM at the top level so the
  node_modules path is added whenever NPM mode is on, regardless of
  where it's declared

* Format code with python black formatter

---------

Co-authored-by: James-Dolinar <James-Dolinar@users.noreply.github.com>

1 of 1 new or added line in 1 file covered. (100.0%)

13741 of 13742 relevant lines covered (99.99%)

1.0 hits per line