dbekaert / RAiDER / c5f7937c-0c60-4288-b09c-cdf8bcfb2bae

53%

dev: 53%

Pull #809

circleci

Cover readZTDFile and the combine-workflow guards with tests

Coveralls flagged this PR's new lines as uncovered: readZTDFile had no tests at
all, and neither did the coordinate backfill or the zero-overlap guard in main().

Writing them turned up a bug in readZTDFile that predates this PR. When a file
has a Date column but no times column, pd.to_timedelta(0, unit='s') returns a
scalar Timedelta, which has no .values for the sum on the next line, so the path
always raised AttributeError. The old except (KeyError, ValueError) did not catch
that either, so it was never masked -- just never exercised. Keep sec a Series in
both branches so to_timedelta returns an array-backed result either way.

The new tests cover every branch of readZTDFile: Date with and without times,
junk times values coerced to midnight, an existing Datetime column, the filename
fallback and its warning, the error when no time information exists at all, and
the col_name rename. Two more drive main() end to end on synthetic delay files to
check that a GNSS file lacking station coordinates inherits them from the RAiDER
file, and that non-overlapping inputs fail with the explanatory error rather than
a KeyError further downstream.

Module coverage over the GNSS suite goes from 18% to 57%, with every line this PR
adds now exercised.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

18 of 18 new or added lines in 1 file covered. (100.0%)

3443 of 6474 relevant lines covered (53.18%)

0.53 hits per line