digidem / multi-core-indexer / 31515029493

100%

push

github

feat!: upgrade to hypercore 11 (#51)

* feat!: upgrade to hypercore 11

* fix: don't swallow pipeline errors that race close()

Replace the per-stream 'error' listeners and hand-rolled close-promise
capture with the streamx pipe callback, which fires exactly once after both
pipeline streams close: with null after a clean teardown, or with the
root-cause error. This removes the guard that deduplicated the same error
arriving from both streams, under which any real failure racing a
deliberate close() was silently dropped.

Because the pipe callback only fires after teardown completes, the indexer
also needs to know the moment the pipeline *starts* dying: the index
streams now emit a 'destroying' event synchronously from their streamx
predestroy hooks (forwarded from source core streams, which previously
could fail invisibly for their whole teardown). During that window
addCore() and idle() now throw instead of feeding a dying pipeline, an
error that preceded a user-initiated close() is still emitted, and
MultiCoreIndexStream.addStream() throws rather than accepting a stream
that would never be destroyed (leaking its storage handle and core
listeners).

* refactor: remove dead bitfield code and cover remaining branches

The hypercore 11 upgrade removed the blanket c8-ignore markers that had
hidden bitfield.js from coverage entirely, exposing its real coverage (90%
branch). Of the six uncovered branch legs: close() was unused outside tests
(the core index stream closes the storage directly) and is removed, the
u === v check in FixedBitfield.set was unreachable (the earlier same-value
check already guarantees the word changes) and is removed, and the
remaining legs (same-value set, clearing a bit on a missing page, and a
storage read failure during open) now have tests.

* test: annotate unreachable error-swallow guard for coverage

The swallow leg of #handleError's guard cannot be reached: an error only
arrives at the pipe callback if a stream was destroy... (continued)

272 of 272 branches covered (100.0%)

Branch coverage included in aggregate %.

250 of 250 new or added lines in 4 files covered. (100.0%)

1120 of 1120 relevant lines covered (100.0%)

76213.67 hits per line