dbekaert / RAiDER / 18f513ef-6bf0-4777-bdcf-b87b9bf5fef6

51%

dev: 55%

Build Type

Pull #808

circleci

Committed by jlmaurer

Commit Message

Revert the merged ECMWF CDS request and pin the download layout with tests

The single combined request for lnsp/z/t/q could not work. ERA-5 archives lnsp
and z at model level 1 only, so a mixed-level request is not something CDS will
return as one netCDF -- the multi-date path added in #810 splits the request for
exactly this reason. Where a single file is returned at all, the surface fields
come back padded onto the full 137-level axis, so .squeeze() no longer collapses
the level dimension and calcgeoh raises:

  ValueError: could not broadcast input array from shape (137,11,11) into (11,11)

reproduced against test/weather_files/ERA-5_2020_01_30_T13_52_45.nc, which was
downloaded by the pre-split single-request path and still carries that layout.

Restore the two requests and keep the rest of the cleanup: the full-cube
shutil.copy is dead (to_netcdf overwrites out_path) and is dropped.

Nothing in CI performs a CDS retrieval, which is why _get_from_cds had no cover
at all. test_ecmwf_fetch.py stubs cdsapi.Client and drives the real
post-processing into the real reader, asserting the layout contract the two
share: t/q/z as (time, level, lat, lon) cubes and lnsp recovered as lnsp[0, 0].
The stub refuses a mixed-level request, so re-merging the two retrievals fails
the suite instead of failing at download time.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Pull Request Pull Request #808: Update xarray usage in RAiDER to use lazy loading

Coverage Stats

33 of 58 new or added lines in 5 files covered. (56.9%)

20 existing lines in 1 file now uncovered.

3313 of 6463 relevant lines covered (51.26%)

0.51 hits per line