• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Chaguar / committer / 31484672330
91%

Build:
DEFAULT BRANCH: main
Ran 11 Aug 2026 11:05AM UTC
Jobs 3
Files 132
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

11 Aug 2026 11:00AM UTC coverage: 91.004% (+0.1%) from 90.904%
31484672330

push

github

web-flow
[test] Never assert on the outer testing.T inside a polling condition (#758)

#### Type of change

- Bug fix
- Test update

#### Description

- Add `test.TestingT`: `require.TestingT` plus `Helper()`, the assertion
surface both a `testing.T` and
an `assert.CollectT` provide. A bare `require.TestingT` cannot call
`Helper`, so helpers taking it
either skipped it (`testapp.RequireStatus`) or open-coded a type
assertion for it
(`test.RequireProtoEqual`); `testing.TB` cannot serve at all, being
sealed by an unexported method
  that no `CollectT` can satisfy.
- Adopt it for every existing `require.TestingT` holder, calling
`Helper` directly and dropping the
open-coded assertions: `test.RequireProtoEqual`,
`RequireProtoElementsMatch`, `testapp.RequireStatus`.
- Widen every helper a polling condition reaches from `*testing.T` to
`test.TestingT`, and pass the
condition's `assert.CollectT` at those call sites, so a failing probe
fails the tick rather than the
test: `DatabaseContainer.GetContainerLogs` and `ExecuteCommand`,
`ProcessWithConfig.requireRunning`,
`CommitterRuntime.requireAllServicesAreRunning`,
`YugaClusterController.runYBAdmin` and
`listAllMasters`, `test.GetMetricValueFromURL`, `GetMetricValue` and
`GetIntMetricValue`, and
  `metricsGetter.value`.
- `requireRunning` reports through `require.Failf` rather than
`t.Fatalf`, which a `CollectT` cannot
offer; `ExecuteCommand` keeps its "executing" log only when a
`*testing.T` was passed.
- `integration/runner`: bound `yb-admin` with `-timeout_ms`
(`ybAdminTimeout`, 5s). Its own default is
  60s, which is the entire budget of the waits in `startNodes`.
- `integration/runner`: register the cluster teardown before the nodes
start, in both
`StartYugaCluster` and `StartPostgresCluster`; `StopAndRemoveContainer`
is a no-op for a container
that was never created, so the earlier registration is safe after a
partial start.
- `utils/test`: fix two single-line faults in the metrics helpers —
`getMetricsFromURL` as... (continued)

10865 of 11939 relevant lines covered (91.0%)

13158.41 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
91.94
-2.84% service/coordinator/signature_verifier_manager.go
5
94.17
-4.17% mock/coordinator.go
1
96.63
-1.12% mock/sigverifier.go
1
94.95
-1.01% loadgen/adapters/common.go
Jobs
ID Job ID Ran Files Coverage
1 core-db-test - 31484672330.1 11 Aug 2026 11:05AM UTC 101
48.4
GitHub Action Run
2 unit-test - 31484672330.2 11 Aug 2026 11:06AM UTC 94
84.55
GitHub Action Run
3 db-test - 31484672330.3 11 Aug 2026 11:05AM UTC 132
79.15
GitHub Action Run
Source Files on build 31484672330
  • Tree
  • List 132
  • Changed 18
  • Source Changed 0
  • Coverage Changed 18
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • cfd60294 on github
  • Prev Build on main (#31478561424)
  • Next Build on main (#31596113754)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc