gluesql / gluesql / 31483015771

99%

push

github

Reject unsupported transaction statement clauses (#1991)

- `START TRANSACTION`, `COMMIT`, and `ROLLBACK` were translated with `..` patterns that silently discarded every clause GlueSQL does not support. The worst case was `ROLLBACK TO SAVEPOINT sp1`: the whole transaction was rolled back while the response claimed success.
- Destructure the three statements explicitly and reject transaction modes (`READ ONLY`, `ISOLATION LEVEL ...`), the SQLite `BEGIN` modifier, `AND CHAIN`, and `TO SAVEPOINT` with a new `TranslateError::UnsupportedTransactionOption(TransactionOption)`, following the existing `InsertOption`-style option enums.
- Add regression tests for each rejected clause (including the `SAVEPOINT`-keyword-omitted `ROLLBACK TO sp1` form and a direct-AST test for the parser-unreachable SQLite modifier) plus positive controls for the plain statement forms.

82 of 82 new or added lines in 1 file covered. (100.0%)

52888 of 53483 relevant lines covered (98.89%)

1550.59 hits per line