PHPOffice / PHPPresentation / 31470671589

92%

push

github

Fix static analysis on PHP 8.4 and 8.5 (#897)

* Fix static analysis on PHP 8.4 and 8.5

PHPStan 1.12 cannot resolve the symbols of PHPUnit 13, which composer
installs on PHP 8.4 and 8.5, so every assertion in the test suite was
reported as a call to an undefined static method (3451 errors) and both
static analysis jobs failed, on master as well as on pull requests.

- Upgrade phpstan/phpstan to ^2.2, the version PHPStan itself recommends
  in its end-of-life notice. It still supports PHP 7.4, so the whole
  matrix keeps working.
- Derive the chart column name from its index in the ODPresentation
  writer instead of incrementing a string, which is deprecated as of
  PHP 8.5 and is the only new finding specific to that version.

The newer analyser reports 144 further findings on the existing code at
level 6. They are fixed rather than silenced:

- Drop the method_exists($this, 'getMockForAbstractClass') fallbacks
  (24 blocks). The anonymous-class branch they guarded works on every
  supported PHPUnit generation, and getMockForAbstractClass() has been
  deprecated since PHPUnit 10 and removed in 12, so dropping it also
  takes 21 deprecation notices out of the suite.
- Remove 47 tautological assertIsArray() calls whose subject is already
  declared array; each is followed by the assertCount() or assertEmpty()
  that carries the real expectation. The four calls on getAnimations(),
  which has no return type, are kept. Replace the 8 assertNotNull()
  calls on int returns with assertSame(0, ...) and the 3
  assertIsString() calls on getHashCode() with assertNotEmpty(), so
  those tests check a value instead of a type the signature already
  guarantees.
- Give the @var tags on mocks the X&MockObject intersection type, and
  correct the ones that had drifted from what is really assigned.
- Drop instanceof and !== null checks on values that are already
  declared with that type: five parameters and the non-nullable return
  of Doughnut::getFirstSliceAngle().... (continued)

40 of 47 new or added lines in 6 files covered. (85.11%)

9878 of 10782 relevant lines covered (91.62%)

42.94 hits per line