• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 31460810996
85%

Build:
DEFAULT BRANCH: main
Ran 11 Aug 2026 05:29AM UTC
Jobs 68
Files 542
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

11 Aug 2026 05:10AM UTC coverage: 83.021% (-0.02%) from 83.037%
31460810996

push

github

AkramBitar
fix(network): remove goroutine leak in transfer-metadata lookup wait

LookupTransferMetadataKey waited for its lookupListener by spawning a
goroutine parked on sync.WaitGroup.Wait(). On the timeout path the
function returns and its deferred RemoveLookupListener tears the listener
down, so OnStatus/OnError -- the only callers of wg.Done() -- never fire
and the goroutine is parked for the life of the process. ScanForPreImage
uses a 5 minute timeout, so every HTLC pre-image that is never revealed
stranded one goroutine.

Buffering the channel does not help: the goroutine blocked on wg.Wait(),
not on a channel send, and the send it replaced was a close(), which
never blocks.

Remove the goroutine instead. lookupListener now owns a done channel that
the first matching notification closes, and the waiter selects on it
against a timer. With nothing parked on the notification there is nothing
to leak. Closing exactly once also removes the "negative WaitGroup
counter" panic a duplicate notification could trigger, and the timer is
explicitly stopped so a lookup that completes early no longer retains one
for the rest of its timeout.

The timeout is reported as a plain error naming the key rather than a bare
context sentinel: a lookup that does not complete in time is an expected
outcome here, and surfacing context.DeadlineExceeded would make it
indistinguishable from caller cancellation to errors.Is-based retry logic.
The context parameter is dropped rather than left dead -- neither
driver.Network.LookupTransferMetadataKey nor htlc.ScanForPreImage carries
a context, so the only caller could pass nothing but context.Background().

The tests are rewritten to actually reproduce the bug: they never release
the listener, since releasing it also let the leaked goroutine exit, which
is why the previous ones passed against the unfixed code. Verified that
goleak flags the pre-fix implementation under these assertions and passes
the new one.

Fixes #2124

Signed-off-by: A... (continued)

25 of 25 new or added lines in 1 file covered. (100.0%)

28 existing lines in 3 files now uncovered.

43118 of 51936 relevant lines covered (83.02%)

12324.41 hits per line

Coverage Regressions

Lines Coverage ∆ File
24
85.33
-3.67% token/services/benchmark/runner.go
2
93.06
-0.33% token/services/identity/membership/lm.go
2
87.4
-0.76% token/services/storage/services/recovery/manager.go
Jobs
ID Job ID Ran Files Coverage
1 itest-dlogstress-t1 - 31460810996.1 11 Aug 2026 05:29AM UTC 481
37.53
GitHub Action Run
2 itest-fabricx-dlog-t16-websocket - 31460810996.2 11 Aug 2026 05:41AM UTC 501
44.57
GitHub Action Run
3 itest-dlog-fabric-t7 - 31460810996.3 11 Aug 2026 05:39AM UTC 481
34.11
GitHub Action Run
4 itest-dlog-fabric-t9 - 31460810996.4 11 Aug 2026 05:35AM UTC 481
34.64
GitHub Action Run
5 itest-dlog-fabric-t5 - 31460810996.5 11 Aug 2026 05:34AM UTC 481
38.94
GitHub Action Run
6 itest-interop-dlog-t4 - 31460810996.6 11 Aug 2026 05:40AM UTC 481
39.31
GitHub Action Run
7 itest-dlog-fabric-t10-libp2p - 31460810996.7 11 Aug 2026 05:38AM UTC 481
44.85
GitHub Action Run
8 itest-update-t1 - 31460810996.8 11 Aug 2026 05:41AM UTC 481
42.61
GitHub Action Run
9 itest-dlog-fabric-t2 - 31460810996.9 11 Aug 2026 05:39AM UTC 481
34.02
GitHub Action Run
10 itest-update-t3 - 31460810996.10 11 Aug 2026 05:45AM UTC 481
38.38
GitHub Action Run
11 itest-fabtoken-fabric-t1-websocket - 31460810996.11 11 Aug 2026 05:38AM UTC 481
34.08
GitHub Action Run
12 itest-interop-fabtoken-t4 - 31460810996.12 11 Aug 2026 05:38AM UTC 481
31.06
GitHub Action Run
13 itest-dvp-fabtoken - 31460810996.13 11 Aug 2026 05:33AM UTC 477
31.45
GitHub Action Run
14 itest-nft-dlog - 31460810996.14 11 Aug 2026 05:32AM UTC 481
37.45
GitHub Action Run
15 itest-dlog-fabric-t8-websocket - 31460810996.15 11 Aug 2026 05:38AM UTC 481
42.65
GitHub Action Run
16 itest-dloghsm-fabric-t1-websocket - 31460810996.16 11 Aug 2026 05:39AM UTC 481
42.33
GitHub Action Run
17 itest-dlog-fabric-t6-libp2p - 31460810996.17 11 Aug 2026 05:38AM UTC 481
42.47
GitHub Action Run
18 itest-fabricx-dlog-t5 - 31460810996.18 11 Aug 2026 05:35AM UTC 501
41.06
GitHub Action Run
19 itest-dlog-fabric-t2.1 - 31460810996.19 11 Aug 2026 05:39AM UTC 481
33.8
GitHub Action Run
20 itest-interop-dlog-t5 - 31460810996.20 11 Aug 2026 05:36AM UTC 481
39.95
GitHub Action Run
21 itest-fabricx-dlog-t1-replicas - 31460810996.21 11 Aug 2026 05:41AM UTC 501
46.17
GitHub Action Run
22 itest-dlog-fabric-t8-replicas - 31460810996.22 11 Aug 2026 05:39AM UTC 481
43.89
GitHub Action Run
23 itest-fabricx-dlog-t6-libp2p - 31460810996.23 11 Aug 2026 05:40AM UTC 501
44.61
GitHub Action Run
24 itest-dlog-fabric-t11 - 31460810996.24 11 Aug 2026 05:36AM UTC 481
33.05
GitHub Action Run
25 itest-fabricx-dlog-t11 - 31460810996.25 11 Aug 2026 05:35AM UTC 501
34.78
GitHub Action Run
26 itest-interop-fabtoken-t1 - 31460810996.26 11 Aug 2026 05:38AM UTC 481
33.22
GitHub Action Run
27 itest-fabtoken-dlog-fabric - 31460810996.27 11 Aug 2026 05:43AM UTC 481
42.01
GitHub Action Run
28 itest-dlog-fabric-t1-replicas - 31460810996.28 11 Aug 2026 05:38AM UTC 481
44.54
GitHub Action Run
29 itest-interop-fabtoken-t5 - 31460810996.29 11 Aug 2026 05:35AM UTC 481
31.7
GitHub Action Run
30 itest-dlog-fabric-t8-libp2p - 31460810996.30 11 Aug 2026 05:38AM UTC 481
42.6
GitHub Action Run
31 itest-interop-dlog-t3 - 31460810996.31 11 Aug 2026 05:39AM UTC 481
40.53
GitHub Action Run
32 itest-fabricx-dlog-t1-libp2p - 31460810996.32 11 Aug 2026 05:40AM UTC 501
44.39
GitHub Action Run
33 itest-nft-fabtoken - 31460810996.33 11 Aug 2026 05:32AM UTC 477
29.84
GitHub Action Run
34 itest-dlog-fabric-t10-websocket - 31460810996.34 11 Aug 2026 05:39AM UTC 481
44.81
GitHub Action Run
35 itest-fabtoken-fabric-t1-replicas - 31460810996.35 11 Aug 2026 05:38AM UTC 481
35.61
GitHub Action Run
36 itest-fabricx-dlog-t4 - 31460810996.36 11 Aug 2026 05:34AM UTC 501
41.07
GitHub Action Run
37 itest-fabricx-dlog-t16-libp2p - 31460810996.37 11 Aug 2026 05:40AM UTC 501
44.55
GitHub Action Run
38 itest-dlog-fabric-t12 - 31460810996.38 11 Aug 2026 05:35AM UTC 481
40.12
GitHub Action Run
39 itest-fabricx-dlog-t16-replicas - 31460810996.39 11 Aug 2026 05:42AM UTC 501
46.35
GitHub Action Run
40 itest-interop-fabtoken-t3 - 31460810996.40 11 Aug 2026 05:37AM UTC 481
32.27
GitHub Action Run
41 itest-dloghsm-fabric-t2-websocket - 31460810996.41 11 Aug 2026 05:37AM UTC 481
42.75
GitHub Action Run
42 utest-unit-tests-race - 31460810996.42 11 Aug 2026 05:32AM UTC 541
73.14
GitHub Action Run
43 itest-dloghsm-fabric-t1-replicas - 31460810996.43 11 Aug 2026 05:40AM UTC 481
43.42
GitHub Action Run
44 itest-dlog-fabric-t3 - 31460810996.44 11 Aug 2026 05:35AM UTC 481
37.48
GitHub Action Run
45 itest-dlog-fabric-t10-replicas - 31460810996.45 11 Aug 2026 05:39AM UTC 481
47.09
GitHub Action Run
46 itest-fabricx-dlog-t3 - 31460810996.46 11 Aug 2026 05:33AM UTC 501
38.9
GitHub Action Run
47 itest-fabtoken-fabric-t3 - 31460810996.47 11 Aug 2026 05:34AM UTC 481
29.41
GitHub Action Run
48 itest-fabricx-dlog-t1-websocket - 31460810996.48 11 Aug 2026 05:40AM UTC 501
44.43
GitHub Action Run
49 itest-fabricx-dlog-t6-websocket - 31460810996.49 11 Aug 2026 05:40AM UTC 501
44.69
GitHub Action Run
50 itest-dloghsm-fabric-t1-libp2p - 31460810996.50 11 Aug 2026 05:39AM UTC 481
42.65
GitHub Action Run
51 itest-dlog-fabric-t6-websocket - 31460810996.51 11 Aug 2026 05:38AM UTC 481
42.9
GitHub Action Run
52 utest-unit-tests-regression - 31460810996.52 11 Aug 2026 05:32AM UTC 541
73.13
GitHub Action Run
53 itest-fabtoken-fabric-t4 - 31460810996.53 11 Aug 2026 05:35AM UTC 481
30.7
GitHub Action Run
54 itest-update-t2 - 31460810996.54 11 Aug 2026 05:40AM UTC 481
37.53
GitHub Action Run
55 itest-dlog-fabric-t1-libp2p - 31460810996.55 11 Aug 2026 05:38AM UTC 481
42.29
GitHub Action Run
56 itest-dlog-fabric-t4 - 31460810996.56 11 Aug 2026 05:34AM UTC 481
38.87
GitHub Action Run
57 itest-fabtoken-fabric-t2 - 31460810996.57 11 Aug 2026 05:38AM UTC 481
27.51
GitHub Action Run
58 itest-dlog-fabric-t1-websocket - 31460810996.58 11 Aug 2026 05:38AM UTC 481
42.68
GitHub Action Run
59 itest-interop-dlog-t1 - 31460810996.59 11 Aug 2026 05:38AM UTC 481
41.35
GitHub Action Run
60 itest-dlog-fabric-t6-replicas - 31460810996.60 11 Aug 2026 05:40AM UTC 481
44.56
GitHub Action Run
61 itest-dloghsm-fabric-t2-libp2p - 31460810996.61 11 Aug 2026 05:38AM UTC 481
42.8
GitHub Action Run
62 itest-fabtoken-fabric-t1-libp2p - 31460810996.62 11 Aug 2026 05:38AM UTC 481
34.31
GitHub Action Run
63 itest-dloghsm-fabric-t2-replicas - 31460810996.63 11 Aug 2026 05:39AM UTC 481
43.98
GitHub Action Run
64 itest-dlog-fabric-t13 - 31460810996.64 11 Aug 2026 05:35AM UTC 481
36.52
GitHub Action Run
65 itest-fabricx-dlog-t13 - 31460810996.65 11 Aug 2026 05:35AM UTC 501
38.7
GitHub Action Run
66 itest-fabricx-dlog-t6-replicas - 31460810996.66 11 Aug 2026 05:41AM UTC 501
46.41
GitHub Action Run
67 itest-fabtoken-fabric-t5 - 31460810996.67 11 Aug 2026 05:34AM UTC 481
30.73
GitHub Action Run
68 itest-dvp-dlog - 31460810996.68 11 Aug 2026 05:33AM UTC 481
38.89
GitHub Action Run
Source Files on build 31460810996
  • Tree
  • List 542
  • Changed 92
  • Source Changed 1
  • Coverage Changed 92
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #31460810996
  • 9bd777f9 on github
  • Prev Build on main (#31430567353)
  • Next Build on main (#31467998459)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc