missionpinball / mpf / 31451782197

81%

Build Type

push

github

Committed by bosh

Commit Message

FAST: address review - drop inbound resync, rename settle constant

Per review on #2043:

- Remove _resync_segment and its use in parse_incoming_raw_bytes. Recovering a
  message from un-decodable junk risks treating partial binary lighting data as
  a valid response (RGB bytes can coincidentally match a real header), which is
  worse than retrying. _drain_serial already clears the leftover startup burst
  before the handshake, so the parser can go back to raising/dropping bad data
  instead of guessing at it.
- Rename RESPONSE_DRAIN_PASSES -> RESPONSE_SETTLE_PASSES: it counts event-loop
  yield passes in _wait_for_processed, not serial draining (which now genuinely
  happens in _drain_serial), so the old name collided. Dial 50 -> 20 (observed
  worst case ~6 passes; each pass is just an asyncio.sleep(0) yield).
- max_retries default stays at 3 per review (resolve noop).

Tests updated to match: drop the resync cases, keep the parse raise/drop and
_drain_serial coverage. Full FAST suite passes (33 tests).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

47 existing lines in 1 file now uncovered.

25748 of 31675 relevant lines covered (81.29%)

7.94 hits per line