lsm / HyperNeo / 31448666994

80%

Build Type

push

github

Committed by web-flow

Commit Message

feat(space): resolve workflow runs through pinned definition versions (RFC §4 Phase 1) (#2432)

* feat(space): resolve workflow runs through pinned definition versions (RFC §4 Phase 1)

Lands the Phase 1 read cutover deferred by #2412/#2425. In-flight runs now
resolve their definition through the immutable version pinned at creation via
getWorkflowForRun (manager, sanitized; and a raw variant on the repository for
delivery-permission reads), instead of re-reading the mutable head every tick.
A startup backfill (backfillDefinitionPins) stamps every pre-existing run with
its current head's version, so the cutover is content-neutral for active runs;
legacy/deleted-head runs fall back to the live head, preserving today's behavior.
An edit to a definition after run creation no longer changes what the run
executes. Covers all 23 execution read sites; new-run/display reads stay on the
head. Built-in gate-script pinning (RFC §4 #2) remains a tracked boundary.

* feat(space): finish Phase 1 read cutover — agent/spawn paths + review fixes

Addresses PR #2432 review (REQUEST_CHANGES). Completes the cutover the
partial-state P1 flagged: convert the 15 remaining execution-read sites
(task-agent-manager x13, actor-registry x2) to getWorkflowForRun, closing the
split-brain where routing saw the pinned topology but agent identity/spawn/
activation/MCP/post-approval-worker saw the head. actor-registry's cache is now
keyed by (workflowId, version) so runs of the same workflow pinned to different
versions don't conflate.

P2s: manager.getWorkflowForRun now delegates to repo.getWorkflowForRun + sanitize
(single pin-resolution implementation); removed the now-unused repo.getDefinitionVersion;
reconciled the built-in gate boundary wording (BUILT_IN_TEMPLATE_GATES is a
compile-time static map — stable within a version, not pinned across upgrades per
RFC §4 #2). Added tests: lazy-activation regression guard (edit a slot after run
creation → activated slot matches the PIN), J... (continued)

Coverage Stats

20506 of 57908 branches covered (35.41%)

Branch coverage included in aggregate %.

58 of 114 new or added lines in 15 files covered. (50.88%)

5 existing lines in 3 files now uncovered.

30528 of 68494 relevant lines covered (44.57%)

279.21 hits per line