Chia-Network / chia-blockchain / 31430538084

92%

Build Type

push

github

Committed by web-flow

Commit Message

CHIA-4264: Continue Wallet Subscriptions After a Single Peer Fails (#21245)

* Continue wallet subscriptions after a single peer fails

One bad peer in _process_new_subscriptions previously aborted the whole
batch, leaving later peers without the new PH/coin-id registrations.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use real peers in subscription peer-error test

Replace MagicMock peers with two full nodes and only fail the bad peer's register handlers.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Narrow subscription peer-error handling to RPC failures

Only catch subscribe failures so local apply errors do not ban every peer, and guard peer.close so close exceptions cannot abort the batch.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Tighten subscription failure handling to peer/RPC errors

Catch ValueError/ProtocolError/OSError instead of Exception, and use log_exceptions when closing a failed peer.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Treat protocol Error and StreamableError as subscription peer failures

Normalize Error/unexpected subscribe responses to ValueError, and catch
StreamableError in the per-peer handler so corrupt payloads do not abort the batch.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add unit tests for subscribe response normalization helper.

Cover Error, unexpected-type, None, and success paths without mocking peers.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Drop happy-path unit test for subscribe response helper.

Rejection cases are enough for the coverage gap; success is already exercised elsewhere.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Coverage Stats

11202 of 12361 branches covered (90.62%)

Branch coverage included in aggregate %.

66 of 66 new or added lines in 4 files covered. (100.0%)

17 existing lines in 7 files now uncovered.

115622 of 125575 relevant lines covered (92.07%)

1.84 hits per line