NVIDIA / gpu-operator / 31412954196
38%
main: 38%

LAST BUILD BRANCH: pull-request/2750
DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 38.385%. Remained the same
31412954196

push

github

abrarshivani 
Write the notices file atomically instead of copying over it

compose_document() built the document in a temp file and then used cp to put
it in place, with a comment claiming this stopped a failure part way through
from leaving the committed file truncated. cp does not do that. It opens the
destination, truncates it to zero, and only then starts streaming, so a run
killed with Ctrl-C, or one that hits a full disk, leaves
THIRD_PARTY_NOTICES.md half written in the developer's worktree.

Swapping cp for mv on its own would not have fixed it. OUT_TMP was created
under $TMPDIR, which is frequently a different filesystem from the checkout
(/tmp is tmpfs on most Linux CI images), so rename(2) fails with EXDEV and mv
falls back to copy-then-unlink. That is the same truncate-and-stream window,
just spelled differently.

Create the compose temp file in the destination directory instead, so the
final step is a same-filesystem mv and therefore a real rename(2): the output
is either the previous complete document or the new one, never something in
between. The destination directory is now created before mktemp runs there,
and the mode is set on the temp file rather than after the rename so the file
is never briefly 0600 at its final path. The existing EXIT trap still removes
the temp file, which matters a little more now that it sits next to the
output, where a leak would show up in git status.

The generated document is unchanged.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

5572 of 14516 relevant lines covered (38.39%)

0.44 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31412954196.1 73
38.39
 GitHub Action Run
Source Files on build 31412954196