NVIDIA / nvidia-container-toolkit / 31412906410
44%
main: 44%

LAST BUILD BRANCH: disablechmod
DEFAULT BRANCH: main
Ran
Jobs 1
Files 247
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 43.626%. Remained the same
31412906410

push

github

abrarshivani 
Compose the notices document in place and rename it atomically

generate-notices.sh built THIRD_PARTY_NOTICES.md into a temp file and then
copied it over the committed one. The comment claimed that composing into a
temp file meant a failure part way through could not leave a half-written
document behind, but that is not what cp does: it opens the destination,
truncates it to zero and then streams. Anything that stops the run mid-copy
(Ctrl-C, a full disk, the OOM killer) leaves the committed file truncated or
partly overwritten. Killing a cp shortly after it starts reliably leaves the
destination as neither the old document nor a complete new one.

Switching to mv on its own would not have fixed this. The temp file was created
under $TMPDIR, which is often a different filesystem from the work tree and is
settable by the caller besides. Across filesystems mv falls back to
copy-then-unlink, which reopens exactly the same window.

Create the temp file in the destination directory instead, so the final step is
a same-filesystem mv and therefore a single rename(2). The output is then
either the previous document or the complete new one, never a partial write.
The destination directory is created before mktemp runs, and the existing EXIT
trap still removes the temp file, so an interrupted run leaves nothing behind
next to the output. The chmod moves ahead of the rename, since mktemp creates
0600 and the file should never appear at its final path without being
world-readable.

The generated document is unchanged.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

6660 of 15266 relevant lines covered (43.63%)

0.49 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31412906410.1 247
43.63
GitHub Action Run
Source Files on build 31412906410