dennisdoomen / pathy / 31400294737

96%

push

github

Declare EmbeddedAttribute as partial so it can merge with Reflectify's copy (#153)

Pathy ships as source and compiles into the consuming assembly. It declares
Microsoft.CodeAnalysis.EmbeddedAttribute so its own types can be marked
[Embedded], which tells Roslyn to hide them from every other assembly,
including InternalsVisibleTo friends.

Reflectify is another source-only package by the same author and declares the
same attribute for the same reason. A project that uses both packages therefore
ended up with two declarations of one type in a single compilation, which failed
to build with CS0101.

Declaring the type as partial fixes this. Two partial declarations of the same
type merge into one type instead of colliding, and Roslyn matches [Embedded] by
name, so it does not care how many parts the type came from. Reflectify made the
same change in dennisdoomen/reflectify#170.

For the parts to merge they must have an identical shape, so the type-level
attributes had to go. C# does not allow a non-AllowMultiple attribute to be
repeated across parts of a partial type, so leaving [AttributeUsage] in place
would fail with CS0579 and defeat the purpose. Dropping it costs nothing because
AttributeTargets.All is already the default when an attribute carries no
[AttributeUsage]. [ExcludeFromCodeCoverage] was removed for the same reason.

Verified with a scratch consumer project that compiles Pathy's sources next to
Reflectify's declaration: the library builds, a friend assembly can still reach
the library's own internal types, and Pathy types remain hidden from it.

Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

98 of 100 branches covered (98.0%)

Branch coverage included in aggregate %.

239 of 247 relevant lines covered (96.76%)

153.35 hits per line