dennisdoomen / reflectify / 31399659270

98%

push

github

Ensure that internal code is never exposed through InternalsVisibleTo (#170)

* Ensure that internal code is never exposed through InternalsVisibleTo

Reflectify is a source-only package, so its types are compiled directly
into the consuming assembly. Until now those types were plain internal
types, which means any assembly listed in the consumer's
InternalsVisibleTo could see and use them. That makes Reflectify part of
the consumer's internal API surface without the consumer asking for it.

Mark every type with [Microsoft.CodeAnalysis.Embedded] when compiled into
a consumer. Roslyn hides embedded types from all other assemblies,
including friend assemblies. Inside Reflectify's own build the types stay
public instead, which lets the spec project reference them normally and
allowed the InternalsVisibleTo entry to be dropped.

This ports dennisdoomen/pathy#54.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Let a duplicate EmbeddedAttribute merge instead of collide

Pathy is also a source-only package and declares the same
Microsoft.CodeAnalysis.EmbeddedAttribute. A consumer using both compiles
two copies into one assembly, which is a duplicate type error.

Declaring the attribute as partial makes the two declarations merge into
a single type. This needs no cooperation from the consumer, so the
REFLECTIFY_EXCLUDE_EMBEDDED_ATTRIBUTE opt-out is no longer needed.

Partial types cannot repeat a type-level attribute across parts, so
[AttributeUsage] and [ExcludeFromCodeCoverage] had to go. Dropping
[AttributeUsage] changes nothing, because AttributeTargets.All is already
the default. Three analyzers ask for it back, so suppress them here.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

209 of 222 branches covered (94.14%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

403 of 410 relevant lines covered (98.29%)

5365877.43 hits per line