source-academy / backend / c8b8567f1e52bb9e95b6346a1ae6ee6bf801c6dc

90%

Build Type

push

github

Committed by web-flow

Commit Message

Fix 422 on grading save when no AI comment log exists (#1381)

update_final_comment/2 returned {:error, :not_found} whenever an
answer had no AI-comment log row (i.e. the grader never used the
AI-assisted commenting feature), which is the case for the vast
majority of submissions. The controller treated any {:error, _} as a
changeset failure and returned 422, so saving grading changes from
the Grading tab failed with "Error while communicating with backend:
422" on essentially every submission, since the frontend calls
save-final-comment on every grading save regardless of whether AI
comments were ever generated.

Treat a missing AI comment log as a no-op success instead of an
error, since there's nothing to attach the final comment to.

Fixes source-academy/frontend#4233


Claude-Session: https://claude.ai/code/session_011Lfqxf3TfRtt4PLB92u11S

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

2 existing lines in 2 files now uncovered.

3997 of 4568 relevant lines covered (87.5%)

13786.1 hits per line