ilyabrin / disk / 31368935325

78%

push

github

feat: new API options, retries, CI fixes and rewritten docs

Fix the failing Security Checks workflow, close real gaps against the
Yandex Disk REST API, and clean up long-standing defects.

CI and tooling:
- govulncheck no longer fails to install: the tool needs a newer toolchain
  than the module, so build it with GOTOOLCHAIN=auto
- gosec runs with -no-fail so the SARIF report is always uploaded
- bump checkout/setup-go to v7, codeql-action to v4, gosec to v2.28.0,
  dependency-review to v5, coveralls to v2.3.8
- go.mod moves from the EOL Go 1.20 to 1.23; tests now run with -race
- group dependabot updates; fix the broken build path in the Dockerfile

New API coverage:
- fields, media_type, sort, preview_size and preview_crop parameters
  (ResourceOptions.Fields, FilesOptions, GetSortedFilesWithOptions)
- public resources gain path/sort/limit/offset/preview support plus
  GetDownloadURLForPublicResourceAt and SavePublicResourceWithOptions
- GetOperationStatus and OperationIDFromHref for polling async operations

Fixes:
- EmptyTrash sent force_async=false when asked to force async
- RestoreFromTrash dropped the link returned with 201
- validatePath rejected legitimate names containing ".." and used
  filepath semantics for POSIX Disk paths
- multipart upload mutated the shared HTTPClient.Timeout, a data race;
  it now bounds itself through the request context
- progress callbacks divided by zero for zero-length inputs
- MIME sniffing could truncate on a short read
- gosec: directory permissions, unchecked Close, annotated G304 sites

Improvements:
- MaxRetries is now implemented: bodyless requests retry on connection
  errors, 429 and 5xx with exponential backoff
- EnableDebugLogging and a configurable BaseURL are now honoured
- collapse ~300 lines of duplicated decode logic into requestJSON[T]
- WaitForBatchOperation actually polls instead of pretending to
- README and README.ru rewritten and verified to compile

250 of 269 new or added lines in 8 files covered. (92.94%)

1859 of 2398 relevant lines covered (77.52%)

16.51 hits per line