dg / ai-access / 31355232649

93%

push

github

chat: a stream can be cancelled from the loop, not just from a callback

Returning false from the onStream callback already stopped the generation, but a
foreach had no way to say the same thing. Breaking out only pauses: the Fiber
lives on the TextStream rather than in the generator, so the request stays open,
which is exactly what lets a later foreach resume it and getResponse() finish it
without paying twice. Advising unset() instead was a poor substitute, because a
caller cannot know how many references are still held.

cancel() resumes the Fiber with false, which travels back through the emit
callback and aborts the transfer, so the connection closes and the rest of the
answer is neither produced nor billed.

The Fiber's generic types were wrong and PHPStan only noticed once a value other
than null was passed in: resume() takes what suspend() returns, so the order is
Fiber<void, ?bool, Response, string>, not <void, string, Response, string>.

8 of 8 new or added lines in 1 file covered. (100.0%)

2006 of 2179 relevant lines covered (92.06%)

0.92 hits per line