Kikobeats / parse-proxy-uri / 31317223135

97%

push

github

fix: apply http↔socks protocol mutations (#28)

* fix: apply http↔socks protocol mutations

WHATWG silently ignores protocol assignments between special schemes
(http/https) and non-special ones (socks*), so `proxy.protocol = 'socks5:'`
left the proxy on HTTP CONNECT with no error. Rebuild via href when the
native setter no-ops so the documented mutation contract holds.

* refactor: table-drive protocol mutation writes

Drop the setter-loop protocol branch; always assign via href so
special↔non-special scheme switches share one write path.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor: unify ProxyURL mutations behind one applicator

Setter loop no longer branches on encode/authority/protocol — each
field mutator returns an optional authority token for validation.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor: make the mutation table declarative again

Each entry now names what differs (encode, authority, write) instead of
carrying its own `set.call`, so the setter loop owns the single write site
and `protocol` stops bypassing the applicator it was handed.

Restores the allocation-free pathname check and the hostname destructure in
assertValidProxy, hoists the two per-call regexes, and covers the two branches
the previous shape left untested.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PUyFcup3KwDoj7q5CbMovq

* refactor: splice the scheme instead of rebuilding the href

A protocol write reused `toString`'s serializer, so it re-derived the href
from already-canonical getters and left `assertValidProxy` nothing to check.
Splicing onto the live href keeps the write surgical and the shared validator
load-bearing for every setter.

Also drops the inert `authority ?? hostname` fallback (a dotted-quad hostname
tokenizes to itself), and folds the ftp case into the protocol switch table.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claud... (continued)

67 of 67 branches covered (100.0%)

Branch coverage included in aggregate %.

58 of 58 new or added lines in 1 file covered. (100.0%)

186 of 186 relevant lines covered (100.0%)

67.16 hits per line