Kikobeats / router-http / 31305711502

99%

push

github

fix: keep path middleware aligned with route normalization (#36)

* fix: keep path middleware aligned with route normalization

find-my-way can still match routes after collapsing duplicate slashes,
stripping semicolon delimiters, or folding case, while .use() mounts were
matched against the raw path — skipping auth middleware. Also run
onBadUrl/onMaxParamLength handlers instead of crashing on .handlers.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* test: cover onBadUrl with raw http client

got rejects malformed percent-encoding before the request is sent, so the
onBadUrl regression uses Node's http client like the existing bad-URL test.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* fix: mirror find-my-way fragment and absolute-form normalization

find-my-way truncates the lookup path at the first `#` unconditionally and
rewrites absolute-form request targets before matching. Neither was mirrored,
so `GET /admin#x` and `GET http://host/admin/secret` matched a route while
skipping its `.use()` mount, on default options.

Option detection now follows find-my-way's truthiness (`ignoreDuplicateSlashes`,
`useSemicolonDelimiter`) instead of `=== true`, and `caseSensitive` mirrors both
sides separately: routes are lowercased on `!caseSensitive`, the lookup path on
`caseSensitive === false`.

Mount stripping re-adds the leading slash whenever the remainder is not already
rooted, covering `;` and `#` remainders.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XYfkdSmf8BZzjm1oqP26A2

* fix: scope req.url rewriting and align query with the path delimiter

The req.url rewrite ran before any lookup, so a router mounted as connect
middleware handed a normalized url downstream even when it matched nothing
and delegated via next(). Only a matching .use() mount strips a prefix off
req.url, so only that path needs the rewrite.

req.path stopped at `#`/`;` while... (continued)

187 of 189 branches covered (98.94%)

Branch coverage included in aggregate %.

411 of 411 new or added lines in 1 file covered. (100.0%)

536 of 538 relevant lines covered (99.63%)

2812.51 hits per line