dangernoodle-io / breadboard / 31279088948

97%

push

github

feat: warn when a bb_data_http client holds frames with no send seam (#1262)

- a client acquired with neither a per-client send_fn nor a module-wide
default installed is otherwise silently dead -- it holds a client slot
and accumulates frames in its outbound queue until they are evicted,
with no crash and no log

- rejecting this at bb_data_http_client_acquire() time was considered and
rejected: bb_data_http_set_send_fn() is deliberately decoupled from
client lifetime and can be installed after a client is already
acquired -- several existing host tests rely on exactly that ordering,
and a client with an empty queue may simply be pre-install (the shape
a future MQTT consumer will follow), so a hard reject at acquire would
break legitimate, load-bearing usage

- add a one-shot WARN in the flush loop instead, fired only when the
loop skips a client for a NULL seam and that client is also holding
queued frames it can never send; gated by a new per-client
warned_no_send_fn flag, reset on acquire so slot reuse never inherits
a prior occupant's warned state

- add a host-testable _for_test accessor for the new flag and host tests
covering the warn-once, later-recovery, per-client-seam, and
slot-reuse-reset cases

8529 of 9048 branches covered (94.26%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

14293 of 14448 relevant lines covered (98.93%)

2601.74 hits per line