kaidokert / krabiecdsa-rs / 31275848269

93%

push

github

API cleanup (1/3): drop the redundant public sign free-fns (#33)

Signing has a full RustCrypto trait + key-type surface, so the raw
byte-slice sign free-fns are redundant public API. First of the pre-0.4.0
traits-first cleanups.

- Delete sign_prehashed_ct_hedged_verified — it had zero callers (the
  RandomizedSigningKey path uses the internal sign_hedged_verified_with_pubkey).
- Move sign_prehashed_ct and sign_prehashed_ct_hedged behind the
  test-vectors feature (KAT-harness entry points), so the default public
  sign API is the key types + traits (SigningKey / PrehashSigningKey /
  RandomizedSigningKey + PrehashSigner / RandomizedPrehashSigner /
  DigestSigner / RandomizedDigestSigner / Keypair). SigningKey::sign_prehashed
  now calls the always-present internal core.
- cross_impl migrates to PrehashSigningKey (tests the production API, not a
  gated free fn); the two explicit-`added` hedged unit tests + their helper
  move behind test-vectors alongside the fns they exercise.

The ct-verify fixtures already build with test-vectors, so their taint /
panic-audit coverage of the sign-only hedged path is unchanged.

6 of 6 new or added lines in 1 file covered. (100.0%)

799 of 841 relevant lines covered (95.01%)

20038.52 hits per line