dennisdoomen / fluentassertions / 31269214548

97%

develop: 97%

Build Type

push

github

Committed by Dennis Doomen

Commit Message

Allow empty expectation for BeSupersetOf and BeProperSupersetOf

Addresses jnyrup's review feedback on #3271: BeSupersetOf and
BeProperSupersetOf previously threw ArgumentException when the
expected collection was empty, which was inconsistent with
BeSubsetOf/BeProperSubsetOf (an empty set is trivially a subset of
everything, so a superset check against an empty expectation should
never throw).

- Split the empty-argument guard out of AssertContainment behind an
  allowEmptyExpectation flag so Contain keeps its existing behavior
  while BeSupersetOf/BeProperSupersetOf now evaluate normally instead
  of throwing.
- BeSupersetOf(empty) now always passes.
- BeProperSupersetOf(empty) now passes when the subject is non-empty
  and fails (not throws) when the subject is also empty, since two
  empty collections are identical rather than a proper superset.
- Rewrote the XML doc comments for BeSubsetOf/BeSupersetOf/
  BeProperSubsetOf/BeProperSupersetOf in plain language, removing set
  notation and math jargon, and dropped the now-inaccurate
  ArgumentException doc entries for the superset methods.
- Wrapped single-element expectations in curly braces in the new
  superset failure messages, matching how multi-element collections
  are already rendered.
- Added missing spec coverage: null expectation, both empty, and
  equal-non-empty collections for BeSupersetOf, BeProperSubsetOf and
  BeProperSupersetOf.
- Updated docs/_pages/collections.md and releases.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Coverage Stats

4112 of 4392 branches covered (93.62%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13210 of 13435 relevant lines covered (98.33%)

67225.06 hits per line