lsm / HyperNeo / 31268256751

79%

push

github

Fix dev CI: CLI Tests workflow (vitest path) + stabilize flaky startup-timeout test (#2405)

* ci: invoke CLI tests via bunx vitest instead of missing root .bin path

Bun does not hoist per-package devDeps (vitest) to the root node_modules/.bin,
so `../../node_modules/.bin/vitest` from packages/cli resolved to a path that
does not exist and the test-cli job failed every dev push with exit 127 since
the #2364 Vitest migration. Use `bunx vitest run`, matching the web-tests job.

* test(daemon): stabilize flaky startup-timeout convo test

The startup-timeout-no-retry online test flaked ~25-40% locally (and
intermittently on dev CI) in two ways:

  1. waitForIdle timing out in the test body (15s budget too tight given the
     forced 10ms startup timeout drives a retry with a up-to-5s subprocess-exit
     wait before idle).
  2. models.list timing out in createDaemonServer's beforeEach (the 10ms value
     made the daemon abort/respawn the SDK subprocess so fast it congested the
     shared dev proxy, slowing the daemon's own model fetch past the 8s default).

Root cause is the artificial timing pressure, not a logic bug. Fixes:
  - Bump FORCED_STARTUP_TIMEOUT_MS 10ms -> 100ms: still far below any realistic
    SDK startup (subprocess spawn alone is hundreds of ms), so the
    startup-timeout -> retry-once path is still exercised deterministically, but
    without congesting the shared dev proxy.
  - Give waitForIdle / setup budgets enough headroom for the retry's
    subprocess-exit wait and spawn variance.
  - Add an optional modelsReadyTimeoutMs to createDaemonServer so a test that
    deliberately stresses the daemon can request a larger model-readiness budget.

Verified: 10/10 consecutive dev-proxy runs pass (was 5/8 then 6/8); sibling
multiturn-conversation test still passes; CLI + typecheck clean.

* test(daemon): fix stale comments in startup-timeout test (review feedback)

- Drop the 'STARTUP_TIMEOUT_MS=10' / 'within 10 ms' references now that
  ... (continued)

19824 of 56466 branches covered (35.11%)

Branch coverage included in aggregate %.

29773 of 67163 relevant lines covered (44.33%)

275.93 hits per line