bleedingdeacons / sentinel / 31238108703

91%

push

github

fix: guard preg_replace() nulls in the wp-config writers, PHPStan level 8 (#44)

Level 8 checks calls and property reads against nullable types. Sentinel
reported 7 findings, all preg_replace() returning string|null on a PCRE
failure and that null reaching a string parameter — under strict_types a
TypeError raised part-way through editing the site's wp-config.php.

Two kinds of call site, handled differently:

Rewrites that produce the content being written are guarded to abort.
setWpConfigConstant() takes both its rewrite branches through
preg_replace(), so one guard before atomicWrite() covers them;
removeWpConfigConstant()'s define()-stripping replace is guarded the same
way. Failure leaves wp-config.php untouched, matching the file_get_contents()
and is_writable() guards already above them.

The trailing "/\n{3,}/" blank-line tidy is cosmetic and runs after the
removal has already succeeded, so a failure there keeps the uncollapsed
content rather than throwing the removal away. Three sites: SettingsPage,
UnityControlPage::removeKillSwitch() and its production-constant twin —
both of which already guarded their first preg_replace() and only missed
this one.

No baseline entries added. phpstan, phpcs and 190 tests green.

11 of 13 new or added lines in 2 files covered. (84.62%)

1711 of 1888 relevant lines covered (90.63%)

4.34 hits per line