bleedingdeacons / confur / 31238104668

95%

push

github

fix: close null-safety gaps and raise PHPStan to level 8 (#64)

Level 8 checks calls and property reads against nullable types. Confur
reported 8 findings, in three shapes.

get_post() returns null, and AnswerRepository read straight through it:
->post_date twice inside the findDuplicate() usort comparator, and
->post_name on the returned slug. A post deleted between the query and the
comparison is a fatal mid-sort. Missing posts now sort as the oldest
possible date, and the slug falls back to '' — callers act on the post_id.

normalizePostId() returns ?int (null for an empty meeting field) and both
AnswerRepository and AnswerHandler passed it straight to get_the_title(),
which takes int|WP_Post. Guarded, falling back to an empty title.

Three shortcode callbacks passed ?string $content into a string parameter.
WordPress passes null for a self-closing shortcode, which is how all three
are normally written, so this was a live TypeError under strict_types —
the same shape fixed in trumpet during the level 7 sweep. Coalesced to ''.

No baseline entries added. phpstan, phpcs and 361 tests green (the 4
warnings and 1 deprecation are pre-existing, identical on main).

9 of 10 new or added lines in 4 files covered. (90.0%)

2269 of 2391 relevant lines covered (94.9%)

4.08 hits per line