NVIDIA / gpu-operator / 31216296405
38%
main: 38%

LAST BUILD BRANCH: pull-request/2750
DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 38.385%. Remained the same
31216296405

push

github

abrarshivani 
Run notices-check on every build instead of behind a path filter

The changed-paths filter was wrong in three independent ways, so remove
it rather than patch it.

It could not see the change it most needed to catch. The runtime
inventory is the import closure of ./cmd/..., so it moves when ordinary
.go files change their imports, not only when go.mod or vendor/ move. A
PR adding an import of an already-vendored module would pass green and
the failure would surface later on main.

Its base computation was also broken. 'git fetch --depth=1' on the full
clone that fetch-depth: 0 had just made writes .git/shallow and grafts
main's tip as a parentless commit, after which git merge-base finds no
common ancestor and exits 1. The failure sat inside a command
substitution, so the empty result reached git diff as a revision and the
step died with exit 128 rather than reporting anything useful. It also
diffed against main unconditionally, which is the wrong base for the
cherry-pick PRs this repo opens against release-* branches.

A gate that can silently pass is worth less than the runner minutes it
saves, so the job now checks out, installs Go and runs make
notices-check. This also drops the fetch-depth: 0 checkout it needed.

In notices-check, do the cheap tracked-file test before spending minutes
regenerating. In the release workflow, pass the tag through the
environment rather than interpolating it into the script, matching
release.yaml and release-image-list.yaml; git allows shell
metacharacters in tag names.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

5572 of 14516 relevant lines covered (38.39%)

0.44 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31216296405.1 73
38.39
 GitHub Action Run
Source Files on build 31216296405