lsm / HyperNeo / 31210968506

40%

push

github

feat(github-events): normalize merge_group webhook (merge queue) [#2326] (#2352)

* feat(github-events): normalize merge_group webhook (merge queue) [#2326]

Add merge_group (merge-queue checks_requested/destroyed) to GitHubEventKind
per the locked taxonomy in docs/design/github-events-merge-blocking-spec.md
(row 6), with a dedicated normalizer, mapEventType case, and unit tests.

merge_group is a GitHub App-only webhook event — not deliverable via the
daemon's repository webhooks today — so it is added to WEBHOOK_EVENTS but
excluded from REQUIRED_WEBHOOK_EVENTS (required would flag every repo-webhook
user's health panel). The caveat is documented; the live merge-queue signal
remains pull_request enqueued/dequeued (row 8).

The payload has no pull_request object and head_sha is the queue's synthetic
commit (never a /pulls head), so the PR is parsed best-effort from head_ref
(refs/heads/gh-readonly-queue/<base>/pr-<N>-<sha>), anchored to the final
path component. PR-scoped topic: pull_request/<id>.merge_group_checks_requested
/ .merge_group_destroyed. dedupeKey uses headSha as the {kind}:{id}:{version}
version so re-enqueue cycles aren't short-circuited.

* feat(github-events): project merge_group refs/headSha into event essence [#2326]

Add a merge_group branch to formatExternalEventEssence so the injected
essence carries headSha/headRef/baseRef/baseSha/headCommitId (matching
every other SHA-bearing event: pull_request/check_run/check_suite/status/
deployment). Previously the SHA was dropped and body was '' — merge_group
was the lone exception. Adds an essence-contract test asserting the
projection and rawPayload exclusion; summary stays excluded by contract.

* fix(github-events): exclude app-only merge_group from repo-hook requests [#2326]

merge_group is a GitHub App-only webhook event; requesting it on a
repository hook (POST/PATCH /repos/{o}/{r}/hooks) is rejected by GitHub,
which would break createRemoteWebhook/updateRemoteWebhook for every
repo... (continued)

19483 of 55594 branches covered (35.05%)

Branch coverage included in aggregate %.

29248 of 66100 relevant lines covered (44.25%)

277.79 hits per line