bleedingdeacons / confur / 31199151521

95%

Build Type

push

github

Committed by web-flow

Commit Message

fix: close a path-traversal gap in the email template loader, raise PHPStan to level 7 (#62)

EmailService::renderTemplate() checked `$realPath === false` but not
`$emailsDir`, which realpath() can also return false for. strpos($x, false)
compares against '"'"''"'"' and returns 0, so an emails directory that failed to
resolve would have *satisfied* the containment test rather than failing it -
the traversal guard was open in exactly the case it was written for. Both
are checked now, and an unreadable file_get_contents() no longer flows on
as false.

The rest of the nineteen findings:

- file_get_contents() unguarded again in EmailTemplateAdminPage;
  file_exists() does not promise readable.
- min()/max() keyed off a count instead of the array, which does not prove
  non-emptiness.
- get_permalink() and json_encode(), string|false, passed to EmailService.
  Sends now carry an empty string rather than false; the one on the
  status screen stops instead, since a confirmation with no link is worse
  than none.
- generateUniqueSlug() returns false on failure and was going straight into
  wp_update_post as post_name. Now omitted so WordPress derives the slug.
- AcfHelper passed its int|string post id to get_post()/clean_post_cache().
  Non-numeric ids already returned false one line later; now they are
  rejected explicitly rather than cast by WordPress.
- The registered-groups lookup read ->ID off an unshaped object. Object and
  array branches are now one expression, via a cast.
- getDayName() reached $wp_locale through method_exists(), which narrows to
  class-string|object and so has no methods to call. Routed through
  is_callable() instead - the duck typing is deliberate and pinned by a
  test that passes an anonymous class, so instanceof WP_Locale was not an
  option.

Coverage Stats

23 of 33 new or added lines in 6 files covered. (69.7%)

2 existing lines in 1 file now uncovered.

2268 of 2389 relevant lines covered (94.94%)

4.08 hits per line