bleedingdeacons / concordance / 31199144158

94%

push

github

fix: do not cache under a colliding key, and raise PHPStan to level 7 (#40)

The cache key was md5(wp_json_encode($queryArgs)) with no check on the
encode. wp_json_encode() returns false on failure and md5(false) is
md5('"'"''"'"'), so every distinct query would have shared one key and been
served another query'"'"'s results. It now bypasses the cache instead.

ApiClient similarly assigned wp_json_encode($body) straight into the
request args; a failed encode would have sent a well-formed POST with no
body. It now returns a WP_Error.

getFormattedLastUpdate() returned wp_date()'"'"'s string|false against a
string signature, and now falls back to the raw value like the
unparseable-timestamp branch above it.

The three ConcordanceCli findings were not missing is_wp_error() checks -
those were already there. WP_CLI::error() only exits when its $exit
argument is left at the default, which the signature does not say, so the
guards now return explicitly.

8 of 16 new or added lines in 4 files covered. (50.0%)

1200 of 1266 relevant lines covered (94.79%)

6.95 hits per line