supabase / cli / 31197552621
65%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 229
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.861% (+0.2%) from 64.699%
31197552621

push

github

web-flow 
fix(cli): port db reset local recreate to native TS (CLI-1955) (#6026)

## Stacks on supabase/cli#6022

This PR is based on
`columferry/cli-1954-port-db-start-container-bootstrap-natively-and-remove-the`
(supabase/cli#6022), not `develop` — it needs to edit that PR's new
`legacy/shared/db-bootstrap/` code before supabase/cli#6022 has merged.
GitHub will show supabase/cli#6022's diff here too until that PR merges;
once it does, this PR's diff will narrow to just what's described below.

## What changed

`supabase db reset`'s local path delegated its container-recreate work
to the bundled Go binary via a hidden `db __db-bootstrap --mode
recreate` / `--mode await-storage` seam. Ports this to native TS and
**deletes the seam entirely** (both files).

The issue's premise — that reset "reuses the same
create/health/SetupLocalDatabase chain the native start port already
implements" — was wrong. Go's `resetDatabase15`
(`internal/db/reset/reset.go`) never calls `StartDatabase`; it's a
distinctly different composition (no volume-existence probe, no
`--from-backup` concept, unconditional setup with the *resolved*
migration version instead of `""`, no rollback-on-failure, no
`_current_branch` write). This port builds a reset-specific
`legacyRecreateLocalDatabase` directly over the same underlying
primitives `db start` uses, rather than wrapping `legacyStartDatabase`.

Also native now:

* The **PG14 recreate branch**: template1 `DROP`/`CREATE DATABASE`,
disconnect-clients with Go's exact swallow/surface semantics (a genuine
server error surfaces; a node-level socket error or the "database
doesn't exist yet" case is swallowed), replication-slot drain with
backoff, `InitSchema14`/`ApplyApiPrivileges` (deliberately narrower than
the PG15+ `SetupLocalDatabase` — no globals.sql/vault/roles.sql).
* **Concurrent satellite-container restart + Kong** `nginx reload` (the
Kong-reload behavior was added same-day upstream to fix issue
supabase/cli#6016 — this reload **fails th... (continued)

10440 of 16096 relevant lines covered (64.86%)

10.81 hits per line

Coverage Regressions

Lines Coverage ∆ File
42
48.74
 2.43% cmd/db.go
18
74.67
 4.67% internal/db/reset/reset.go
Jobs
ID Job ID Ran Files Coverage
1 31197552621.1 229
64.86
 GitHub Action Run
Source Files on build 31197552621