Qiskit / qiskit / 31193994522

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Parameter expression bugfixes (backport #16283) (#16714)

* Parameter expression bugfixes (#16283)

* Add failing tests

* Fix the bug by removing the wrong optimization for division

* Nested division fix

* Change the nested div optimization to use `SymbolExpr::Value(lv / rv)` throughout

* Fix the bugs in gradient()

* Fix for add/sub of two powers

* remove pow_opt that became dead code after removing a wrong optimization

* Bugfixes for mul expansion and conjugation

* Linting

* Fixes according to PR review

* Additional tests for chain rule

* Linting

* post merge linting

(cherry picked from commit b4073b7ac)

# Conflicts:
#	crates/circuit/src/parameter/symbol_expr.rs
#	test/python/circuit/test_parameter_expression.py

* Fix merge conflicts

* Downgrade to MSRV 1.87.0

---------

Co-authored-by: gadial <gadial@gmail.com>
Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Coverage Stats

38 of 41 new or added lines in 1 file covered. (92.68%)

10 existing lines in 3 files now uncovered.

112889 of 128757 relevant lines covered (87.68%)

997855.92 hits per line