kubeflow / trainer / 31194974915
69%
master: 69%

LAST BUILD BRANCH: fix/validate-numnodes-numprocpernode
DEFAULT BRANCH: master
Ran
Jobs 1
Files 42
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 68.522%. Remained the same
31194974915

Pull #3809

github

sanskar-singh-2403 
fix(api): validate numNodes >= 0 and numProcPerNode >= 1

TrainJob.Spec.Trainer.NumNodes and NumProcPerNode had no lower-bound
validation, so values like numNodes: -3 or numProcPerNode: -5 were
accepted at admission and propagated into the pod spec (the Torch plugin
rendered PET_NPROC_PER_NODE=-5 and set the trainer PodSet count to 0),
failing at pod runtime instead of at admission.

Add +kubebuilder:validation:Minimum=0 to numNodes and an XValidation
self >= 1 rule to numProcPerNode, and regenerate the CRDs so the API
server rejects invalid values at admission. numNodes allows 0 to keep the
API aligned with JobSet's replicas (kubernetes-sigs/jobset#1279), rejecting
only negatives. numProcPerNode stays >= 1 since zero processes-per-node is
meaningless; it uses the same XValidation form as the existing
FluxMLPolicySource.NumProcPerNode contract so the kube-api-linter keeps the
field a pointer (nil means "auto" for the Torch runtime, which a plain
Minimum=1 marker would let the linter strip).

A pre-existing Flux numProcPerNode < 1 integration case expected a
Forbidden error from the plugin webhook; the value is now rejected earlier
by the CRD schema, so its matcher is updated to Invalid.

Closes #3805

Signed-off-by: Sanskar Singh <sanskarsinghty1234@gmail.com>
Pull Request #3809: fix(api): reject zero and negative numNodes and numProcPerNode

2573 of 3755 relevant lines covered (68.52%)

0.8 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31194974915.1 42
68.52
 GitHub Action Run
Source Files on build 31194974915