FlexMeasures / flexmeasures / 31190143802

84%

main: 84%

push

github

Skip vacuous device sign constraints for one-way devices (#2412)

* Skip vacuous device sign constraints for one-way devices

Every device got a power-sign binary and two big-M constraints per time step,
even where one power direction is already fixed to zero by its bounds,
so simultaneous upwards and downwards activation cannot occur anyway.
Both backends now skip those constraints,
and the direct HiGHS backend also leaves the corresponding columns continuous,
so a one-way device (e.g. a heat pump or a one-way charger) adds no binaries at all.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: sign binaries only where both power directions are available

With the vacuous sign constraints skipped, the formulation docs' claim that the sign binaries are part of every model no longer holds:
the model now reduces to a plain linear program when every device is one-way or on a fixed flow, the cost curve is convex, and no device has power bands.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Reference PR #2412 in the changelog entry

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Address Copilot review: docstring shape and unused test variables

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Explain the expected sign-constraint counts in the test

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

9 of 9 new or added lines in 2 files covered. (100.0%)

17207 of 20483 relevant lines covered (84.01%)

0.84 hits per line