Qiskit / qiskit-ibm-runtime / 31154760241

89%

push

github

Add reset_2 (#2903)

### Summary

Added a class `MidCircuitReset` and updated the pass manager
`ConvertToMidCircuitMeasure` to convert reset instructions to `reset_2`.

### Details and comments

Part of #2840 and #2841.

I made a decision which I now think was wrong, but I want to
nevertheless push the PR as it is, in order to hear more opinions before
I revert the (probably wrong) decision.

The decision was to replace the writing of a separate pass manager
`ConvertToMidCircuitReset` with an update to
`ConvertToMidCircuitMeasure` that covers also reset instructions.

Arguments supporting the decision:
1. Users will normally want to convert both, so it will be convenient
for them to call a single pass.
2. The single pass is probably more performant than two executions of
two passes.

Arguments against the decision:
1. With the default value of `mcr_name` being `reset_2` and not `reset`,
it is a breaking change for anyone already running
`ConvertToMidCircuitReset`.
2. May be less performant if only the measure instructions (or only the
reset instructions) are to be converted.
3. More diffs in the PR, making it more difficult to review.

### AI/LLM disclosure

- [ ] I didn't use LLM tooling, or only used it privately.
- [ ] I used the following tool to help write this PR description:
- [x] I used the following tool to generate or modify code: Bob 1.0.3,
Claude Opus 4.6

---------

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Samuele Ferracin <sam.ferracin@ibm.com>
Co-authored-by: Diego M. Rodríguez <diego@moreda.io>

38 of 42 new or added lines in 5 files covered. (90.48%)

9277 of 10418 relevant lines covered (89.05%)

9.74 hits per line