valkyrjaio / valkyrja-php / 31150170942

100%

push

github

[Container] feat!: Remove the implicit new-instance fallback (#1177)

# Description

Remove the container's implicit new-instance fallback and the
`InvalidReferenceMode` enum, so every service needs a binding. The
container
built a class that no binding described, which is the pattern
`CONTAINER_BINDINGS.md` rejects and step 3 of its migration path
removes.

Add `ViewOrkaServiceProvider`, because the Orka replacements were never
bound and
the renderer reads each one from the container. `ViewComponentProvider`
does not
register it, so an application that renders with `PhpRenderer` or
`TwigRenderer`
carries none of its records.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [x] Documentation improvement

## Changes

- **`Container/Manager/Container.php`** — `get()` raises
`ContainerInvalidReferenceException` where nothing resolves the service
id.
- **`Container/Manager/Contract/ContainerContract.php`** — `get()` drops
the mode
  parameter.
- **`Container/Enum/InvalidReferenceMode.php`** — removed.
- **`View/Provider/ViewOrkaServiceProvider.php`** — new. Binds each
replacement
  that the default Orka config selects.
- **`Http/Server/Provider/HttpServerServiceProvider.php`** — binds
  `NoCacheResponseMiddleware`.
- **`Container/README.md`** — states that every service needs a binding.
- **`View/README.md`** — states that Orka needs
`ViewOrkaServiceProvider`.
- **`Event/README.md`** — states that a dispatch by class name needs a
binding.
- **`tests/Tests/Unit/View/Provider/OrkaServiceProviderTest.php`** —
new. Tests
  the Orka service provider.
- **`tests/Tests/Unit/…`** — the container, event, routing, middleware
handler,
  and provider te... (continued)

88 of 0 new or added lines in 0 files covered. (NaN%)

12763 of 12763 relevant lines covered (100.0%)

24.76 hits per line