dangernoodle-io / breadboard / 31132448813

97%

push

github

refactor: collapse bb_serialize_walk/walk_ref into one cfg-struct entry point (#1243)

B1-1459 -- bb_serialize_walk_ref was a wider sibling forwarding into the
same walker as bb_serialize_walk, a banned variant-ladder shape. Both
rungs collapse into a single bb_serialize_walk(const
bb_serialize_walk_cfg_t *cfg), extended by fields (desc/snap/emit
required, resolve/resolve_ctx optional REF resolution). Every field is a
pointer where NULL already carries "unset" semantics, so no zero-default
sentinel is needed. All in-tree callers (bb_serialize_compose,
bb_serialize_console, bb_serialize_json, bb_serialize_logfmt, and every
host test) converted to the cfg-struct call shape.

Flash impact of this change: +37 B net, measured by symbol (xtensa nm on
both firmware.elf files):
  bb_serialize_walk         +20 B (absorbs the former forwarder's body)
  bb_serialize_compose_walk +20 B
  bb_serialize_walk_ref     -42 B (removed)
Call sites in bb_serialize_console.c, bb_serialize_json.c,
bb_serialize_logfmt.c and bb_serialize_meta_openapi.c did not change size
at all -- the compound-literal cfg is materialized on the stack, with no
lost inlining and no rodata copies.

A naive whole-image comparison of the two trees showed +2284 B; this was
NOT caused by this change. examples/smoke/dependencies.lock and
managed_components/ are gitignored, so the two trees resolved
espressif/mdns a week apart and built different versions (1.11.1 vs
1.11.3), accounting for +1311 B, with a further ~544 B of secondary
layout shift in unrelated components (wpa_supplicant, clk_hal). Deleting
.pio/build is NOT sufficient to make two builds comparable; this
reproducibility gap is tracked separately.


Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

8534 of 9074 branches covered (94.05%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 5 files covered. (100.0%)

14282 of 14437 relevant lines covered (98.93%)

2656.68 hits per line