GrottoCenter / grottocenter-api / 31123348658

91%

Build Type

push

github

Committed by ClemRz

Commit Message

fix(massif): address PR review items 3-8

- Use sails.log.error + res.serverError in massif and country
  get-statistics catch blocks so DB failures produce a 500 and
  an error-level log instead of a silent 400
- Add tests: massif absent from view returns 200, soft-deleted
  massif returns 404; add fixture for deleted massif 102
- Rename safeDBQuery to queryFirstRow in StatisticsMassifService
  and StatisticsCountryService; fix JSDoc (drop 'or something
  went wrong')
- Remove isCountryInView from StatisticsCountryService; country
  get-statistics now checks TCountry.findOne like the massif
  controller; remove corresponding service tests
- Coerce massifId to Number() in massif get-statistics controller
- Replace all parseInt with Number.parseInt in massif controller

Coverage Stats

5158 of 6194 branches covered (83.27%)

Branch coverage included in aggregate %.

53 of 59 new or added lines in 7 files covered. (89.83%)

2 existing lines in 1 file now uncovered.

9518 of 10611 relevant lines covered (89.7%)

133.96 hits per line