Eyevinn / moqlivemock / 31100146508

48%

main: 48%

Build Type

Pull #126

github

Committed by tobbee

Commit Message

fix(catalog): order video AVC, HEVC, AV1 and audio AAC, Opus, AC-3

Both track lists were sorted on a string, so the first entry of each was an
accident of the alphabet and the encoder ladder: av01 sorts before avc1, and
audio was ordered on bitrate alone.

That matters because receivers default to the first track of a type.
warp-player does, and its AV1 default made a working build look broken: AV1
carries CTA-608 in a metadata OBU rather than an SEI NAL unit, so an
SEI-reading receiver can play the rendition but never caption it, leaving the
CC button correctly greyed out with nothing to explain why. Audio has the same
shape of problem in a different codec: AC-3 is the narrowest of the three -
Firefox does not decode it, and warp-player's WebCodecs engine handles only
AAC and Opus - so an AC-3 default silences that path.

Rank on a codec prefix rather than the full string, so the profile/level
suffix each codec appends cannot reorder anything, and an unrecognised codec
sorts last instead of displacing a known one. Within a codec the existing
bitrate-ascending order is unchanged, as is AVC ahead of HEVC, which was
already deliberate: HEVC with CENC is not fully supported in Widevine/Chrome.

The video assertion in TestLoadAsset encoded the old alphabetical contract and
is rewritten to the new one; the audio order was previously unasserted and now
is.

Pull Request Pull Request #126: fix(catalog): order video AVC, HEVC, AV1 and audio AAC, Opus, AC-3

Coverage Stats

33 of 43 new or added lines in 2 files covered. (76.74%)

2 existing lines in 1 file now uncovered.

2418 of 5066 relevant lines covered (47.73%)

2043.25 hits per line