supabase / cli / 31099219127
65%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 229
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.704% (+0.03%) from 64.67%
31099219127

push

github

web-flow 
fix(cli): port db start container bootstrap to native TS (CLI-1954) (#6022)

## What changed

`supabase db start` delegated its container-bootstrap step to the
bundled Go binary via a hidden `db __db-bootstrap --mode start` seam.
Ports this to native TS, including the `--from-backup` restore path (a
distinct entrypoint variant, backup bind mount, health-check swallow,
and full setup-skip gate) — which had zero Go test coverage to check
against, so this was verified empirically by executing the real Go
binary and diffing its container-create payload byte-for-byte against
the TS output, rather than relying on reading source alone.

**Avoided duplicating Go's `StartDatabase`.** Go has exactly one
`StartDatabase` function, called by both `db start` and top-level
`supabase start`. Rather than porting a second independent copy of that
sequence (the initial draft did exactly this — caught by review before
merging), extracted a shared `legacyStartDatabase` into
`legacy/shared/db-bootstrap/` that both commands now call, along with
the rest of the container-lifecycle/health-check/db-setup/postgres-spec
machinery `supabase start` already had — hoisted per this repo's "Hoist
Before You Duplicate" rule now that a second command family needs it.

Also:
- Hoisted the already-native `isDbRunning` probe out of the
Go-proxy-named seam service (it's zero-Go-involvement, a plain `docker
container inspect`) — `db start` now composes no Go delegation at all.
- Removed the now-unreachable `case "start"` dispatch arm from the
Go-side hidden seam (`apps/cli-go/cmd/db.go`). The real, customer-facing
`db start` Go command and `StartDatabase` itself are untouched and
remain the parity oracle for this port.

## Why

Part of the M9 "Final Cleanup — Go Removal" milestone.

## Known follow-up (flagged, not silently dropped)

- `legacyStartSetupLocalDatabase` will need `{version, noSeed,
sqlPaths}` params for CLI-1955 (`db reset --local`) to reuse it for the
recreate path.
- The `db-... (continued)

10449 of 16149 relevant lines covered (64.7%)

10.78 hits per line

Coverage Regressions

Lines Coverage ∆ File
65
46.31
 0.82% cmd/db.go
Jobs
ID Job ID Ran Files Coverage
1 31099219127.1 229
64.7
 GitHub Action Run
Source Files on build 31099219127