hyperledger / fabric-x-committer / 31094313559

91%

Build Type

push

github

Committed by web-flow

Commit Message

[serve, connection] Hand the pre-allocated listener over to its consumer (#747)

#### Type of change

- Bug fix
- Test update

#### Description

- `ServerConfig.Listener` now clears the config's reference to the
pre-allocated listener when it
hands it to a server, making the server its sole owner. Releasing a
reservation
(`ClosePreAllocatedListener`) can therefore no longer close a listener a
server is accepting on,
and a non-nil `preAllocatedListener` now means exactly "the config holds
this port".
- `reserveWhileServerDown` drops its `ClosePreAllocatedListener` call:
once the restarted server has
taken the reservation there is nothing left to close, and re-reserving
the same port retries
through `ListenRetryExecute` until the stopping server releases it, so
the helper no longer
  depends on the asynchronous stop having completed first.
- `reserveWhileServerDown` also reserves the HTTP port, which was left
free for the whole outage.

#### Additional details (Optional)

To observe the failure, start a server on a pre-allocated listener,
cancel its context and
immediately close the reservation, in a loop: the asynchronous `Stop`
usually fires grpc-go's quit
event first, but when the close wins, `Serve` returns
`accept tcp 127.0.0.1:<port>: use of closed network connection`.

#### Related issues

- resolves #746

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

17 existing lines in 7 files now uncovered.

10780 of 11868 relevant lines covered (90.83%)

33593.99 hits per line